Bash script problem

[Atheist]

Hi guys,

A friend of mine is having a problem with a bash script hes working on. I was hoping you could help him out. He already started a post over at WHT which can be found here . If you guys can help, either post here or there it matters not. Thanks!

[Atamur]

I think your friend needs to replace

install_softA $*

with

install_softA "$@"

[edit]i haven't done any shell scripting in a few years so i could be wrong[/edit]

[Atheist]

Well slidey took care of it just a bit ago, thanks for the reply though!

[Mong]

Originally posted by Atheist
Well slidey took care of it just a bit ago, thanks for the reply though!

Post the solution, so we may all learn!!

M.

[Joop]

The solution can be found on the page which contained the original question.

[Slidey]

basically the $* and $@ were expanding hte arguments by any spaces, as it seemed to take $1 - $x as one string.. so when we had $5 as "this argument" it expanded it to $5 = this and $6 = argument..

all we did was store each argument in its own variable and pass them individually..

i bet there was an easier version but it worked and it was quick and it meant the guy could carry on his work

[Atamur]

Originally posted by Slidey
basically the $* and $@ were expanding hte arguments by any spaces, as it seemed to take $1 - $x as one string.. so when we had $5 as "this argument" it expanded it to $5 = this and $6 = argument..

all we did was store each argument in its own variable and pass them individually..

i bet there was an easier version but it worked and it was quick and it meant the guy could carry on his work

"$@" (quotes are significant) quotes each $n variable individually.

~>cat t.sh
#!/bin/bash
a() {
  echo "$3"
}

a $*
a "$@"
~>./t.sh a b "c d"
c
c d

So as I posted earlier, simply replacing $* with "$@" in the function call would probably solve his problem (unless I'm missing something).